track staking events history; add staking rewards to validator history #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew7234
force-pushed
the
andrew7234/staking-rewards-pt-1
branch
from
05c599f to
80f41a2
Compare
pro-wh
reviewed
Sep 24, 2024
| if ev, exists := stakingRewards[addr]; exists { | ||
| batch.Queue(queries.ValidatorStakingRewardUpdate, | ||
| vID.String(), | ||
| epoch.epoch-1, // previous epoch |
There was a problem hiding this comment.
can you affirm that this is all right
- staking rewards appear in the first block of the next epoch
There was a problem hiding this comment.
Hm I asked a follow up in core-platform but as of now, the e2e integration tests show that the staking rewards are indeed populated in the first block of the next epoch. However, I'm not sure if there are any failure edge cases where the rewards might be populated in a subsequent block; will ask around.
There was a problem hiding this comment.
also confirmed that the staking rewards don't show up in the second block of the epochs in the e2e tests
Andrew7234
force-pushed
the
andrew7234/staking-rewards-pt-1
branch
from
fc6fb25 to
1dd6b6a
Compare
changelog nit update e2e test files improve error messages remove check for second block in epoch
Andrew7234
force-pushed
the
andrew7234/staking-rewards-pt-1
branch
from
1dd6b6a to
b481846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a chunk of the changes necessary for staking rewards that would be nice to include in the upcoming reindex release. There are two changes: