runtime: store NULL error module/code when no error #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
force-pushed
the
pro-wh/feature/nullerror
branch
from
a68c437 to
d483e96
Compare
|
oop doesn't even build |
|
ok I am informed by CI that consensus also uses the TxError struct. additionally, in consensus nexus land, it really is code NOT NULL and message NULL. with a special code = errors.CodeNoError = 0 for success 🤔 |
|
welp let's undo most of these changes lol |
pro-wh
force-pushed
the
pro-wh/feature/nullerror
branch
from
d483e96 to
159db20
Compare
pro-wh
force-pushed
the
pro-wh/feature/nullerror
branch
from
159db20 to
7cfd53d
Compare
Andrew7234
approved these changes
Sep 3, 2024
|
huh did this no affect any of those e2e regression db dumps? |
|
indeed, we don't dump those columns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in fact the database allows NULL in these columns already, but a part of the analyzer fills in ""/0