-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oasis-style encryption envelope #747
Conversation
722a18c
to
33dd673
Compare
f06312e
to
5c875b4
Compare
33dd673
to
ba591d8
Compare
5c875b4
to
ae7bace
Compare
ae7bace
to
5b0bd01
Compare
159db20
to
7cfd53d
Compare
5b0bd01
to
48698dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this!
the logic for handling these uses these two sets of encrypted stuff differently, so it's fine and/or convenient to have these be separate tx properties. the logic is roughly this: distinctions, btw:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! Lgtm
754d589
to
b0a8a14
Compare
unified the EncryptedData structure |
1533335
to
fd19203
Compare
cross reference #407, getting the EVM-style encryption envelope
cross reference #704, confusion about why method is not known
sample output for the tx in #704, https://explorer.oasis.io/mainnet/sapphire/tx/7224d59e6b74d9b2caf55ab40dfe0757cef4f71c66d3a7aba3de1d267d2ea409