delegations: remove delegations with 0 shares #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
commented
Jun 18, 2024
| @@ -338,15 +338,6 @@ var ( | |||
| escrow_balance_active = chain.accounts.escrow_balance_active + $2, | |||
| escrow_total_shares_active = chain.accounts.escrow_total_shares_active + $3` | |||
|
|
|||
| ConsensusAddDelegationsUpsertReplace = ` | |||
ptrus
force-pushed
the
ptrus/fix/clean-zero-delegations
branch
2 times, most recently
from
0c6ff4c to
919f1a9
Compare
ptrus
force-pushed
the
ptrus/fix/clean-zero-delegations
branch
2 times, most recently
from
6de81ec to
fd295c6
Compare
ptrus
force-pushed
the
ptrus/fix/clean-zero-delegations
branch
from
fd295c6 to
78b8d75
Compare
ptrus
commented
Jun 19, 2024
| @@ -921,6 +921,33 @@ func (m *processor) queueEscrows(batch *storage.QueryBatch, data *stakingData) e | |||
| e.Owner.String(), | |||
| e.ActiveShares.String(), | |||
| ) | |||
| // Ideally this would be merged with the ConsensusDebondingStartDelegationsUpdate query above, | |||
There was a problem hiding this comment.
@mitjat note that the previous version didn't actually work, i had to refactor the CTE into two separate queries.
There are probably other workarounds, but just issuing two queries seemed the least complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the delegations with 0 shares get cleaned up/removed from the table.