api/epochs: Skip 'end_height' for latest epoch #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/fix/latest-epoch
branch
3 times, most recently
from
9926c16 to
063b77c
Compare
mitjat
approved these changes
Jun 18, 2024
storage/client/queries/queries.go
Outdated
| @@ -257,7 +257,8 @@ const ( | |||
| OFFSET $2::bigint` | |||
|
|
|||
| Epoch = ` | |||
| SELECT id, start_height, end_height | |||
| SELECT id, start_height, | |||
| (CASE id WHEN (SELECT max(id) FROM chain.epochs) THEN NULL ELSE end_height END) AS end_height | |||
There was a problem hiding this comment.
Optional:
To simplify the code and bring it more in line with other similar queries, we could abandon the Epoch SQL query and instead expand Epochs with WHERE ($1::bigint IS NULL OR $1::bigint = id).
ptrus
force-pushed
the
ptrus/fix/latest-epoch
branch
from
063b77c to
b368055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/consensus/epochs/<latest_epoch>endpoint for the currently active epoch returns the ever increasing 'end_height'.This is inconsistent with the API spec and also with the
/consensus/epochs. Skip returning theend_heightfor the latest epoch.For
/consensus/epochswe already do this.