Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add pontusx_{test, dev} support #696

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

Andrew7234
Copy link
Collaborator

@Andrew7234 Andrew7234 commented May 21, 2024

Adds support for the incoming pontusx_dev paratime and the rename of the existing pontusx paratime -> pontusx_test

Testing:

  • Ran the current main branch on testnet pontusx for 120 blocks, then switched to this feature branch and ran Nexus on the existing db to confirm that the migrations work as expected.
  • Was able to query blocks from both pontusx runtimes successfully, but didn't find any txs in the first couple hundred blocks. Need to figure out where the first txs are.

todo:

  • bump oasis client-sdk version once a new release is cut [x]
  • confirm whether new pontusxdev runtime will require a new upgrade/deployment of testnet nodes. does it start at 0? edit: yes and yes.
  • db migration to move existing pontusx stuff to pontusx-dev? or could just reindex [x]
    • added migration.
  • test once pontusx dev is available on oasis-node [x]
    Screenshot 2024-05-27 at 2 42 24 PM

@Andrew7234 Andrew7234 force-pushed the andrew7234/pontus-x-2 branch from 61844ef to 79be06c Compare May 27, 2024 18:41
@Andrew7234 Andrew7234 marked this pull request as ready for review May 27, 2024 18:45
@Andrew7234 Andrew7234 changed the title init add pontusx dev support feature: add pontusx_{test, dev} support May 27, 2024
@Andrew7234 Andrew7234 force-pushed the andrew7234/pontus-x-2 branch from 7ea74dc to 13da672 Compare May 27, 2024 18:50
Copy link
Collaborator

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, fix anything if we find a mistake later

LayerCipher Layer = "cipher"
LayerSapphire Layer = "sapphire"
LayerPontusx Layer = "pontusx"
LayerPontusxDev Layer = "pontusx_dev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it weird that we use underscore here but no underscore in the routes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm we could change the routes to have the underscore but it seems a bit strange. we do have to keep the underscore here though to align with the client-sdk config.

config/config.go Show resolved Hide resolved
@Andrew7234 Andrew7234 merged commit b81a092 into main May 27, 2024
16 checks passed
@Andrew7234 Andrew7234 deleted the andrew7234/pontus-x-2 branch May 27, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants