Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression tests #695

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

vitrvvivs
Copy link
Contributor

@vitrvvivs vitrvvivs commented May 20, 2024

It must be pulling data from somewhere, because the tests went from passing to failing 4 days ago, on multiple branches, without any changes.

https://github.com/oasisprotocol/nexus/actions/runs/9105766749/attempts/1
https://github.com/oasisprotocol/nexus/actions/runs/9105766749/attempts/2

Copy link
Collaborator

@Andrew7234 Andrew7234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vitrvvivs vitrvvivs force-pushed the vitrvvivs/edenfast-add-expected-verifiers branch 4 times, most recently from dedc75f to 2b45e71 Compare May 20, 2024 21:58
@vitrvvivs
Copy link
Contributor Author

vitrvvivs commented May 20, 2024

@Andrew7234 The problem was weirder than it first appeared.

...{"CachingProxies":[{"HostAddr":"localhost:9191","TargetURL":"https://sourcify.dev/server"}]}...
{"caller":"kvstore.go:202","level":"info","module":"caching-http-proxy","msg":"(re)opening KVStore","path":"tests/e2e_regression/edenfast/rpc-cache/https_sourcify_dev_server","ts":"2024-05-20T16:17:16.732950183Z"}
{"caller":"kvstore.go:211","level":"info","module":"caching-http-proxy","msg":"KVStore has 0 entries","ts":"2024-05-20T16:17:16.733290529Z"}

The eden test was hitting the cache, while the edenfast one was pulling the list of contracts from the live server, giving then different lists of contracts. And since they use the same expected/*.csv, fixing one by changing the expected csv broke the other.

@vitrvvivs vitrvvivs force-pushed the vitrvvivs/edenfast-add-expected-verifiers branch from 2b45e71 to 950f884 Compare May 20, 2024 22:05
@vitrvvivs vitrvvivs changed the title tests/e2e_regression/edenfast/expected: add missing contracts Fix regression tests May 20, 2024
@vitrvvivs vitrvvivs merged commit cc273b0 into main May 20, 2024
16 checks passed
@vitrvvivs vitrvvivs deleted the vitrvvivs/edenfast-add-expected-verifiers branch May 20, 2024 22:14
@Andrew7234
Copy link
Collaborator

thanks for digging into that, fix looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants