ERC-20 token prices #691
Merged
ERC-20 token prices #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this adds gpl'd code to our repo |
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
from
dc98a8f to
4e52598
Compare
pro-wh
force-pushed
the
pro-wh/feature/blockmeta
branch
from
4c1db1c to
aab2e4d
Compare
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
from
287fbc3 to
9c6302a
Compare
jberci
force-pushed
the
pro-wh/feature/blockmeta
branch
2 times, most recently
from
0cbe365 to
668490f
Compare
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
from
9c6302a to
1b19994
Compare
pro-wh
commented
Jul 25, 2024
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
from
1b19994 to
a7a1a83
Compare
Andrew7234
reviewed
Jul 30, 2024
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
3 times, most recently
from
78b89d3 to
22b47b3
Compare
Andrew7234
reviewed
Aug 20, 2024
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
2 times, most recently
from
c9175a3 to
f227a8f
Compare
Andrew7234
reviewed
Aug 23, 2024
| }, | ||
| { | ||
| Name: "reserve1", | ||
| EvmType: "uint112", |
Comment on lines
+1077
to
+1078
| Token0: token0Addr, | ||
| Token1: token1Addr, |
There was a problem hiding this comment.
Does uniswap enforce some ordering on token0/token1? Like is it possible to create a usdt/wrose pair and then create a wrose/usdt pair that's distinct from it? (and if uniswap combines the pairs, would nexus do the same?)
There was a problem hiding this comment.
my reading of the actual contract is they have to have the lower token address in token0
Andrew7234
approved these changes
Aug 27, 2024
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
from
02677db to
3d2712f
Compare
ironically making the code more complicated imo
pro-wh
force-pushed
the
pro-wh/feature/swapprice
branch
from
a992f5f to
6d55d50
Compare
|
had to disable the gocyclo on visit evm event |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a "relative" token price estimate and total value estimate to the tokens API.
this data comes from on-chain swap contracts. for contracts that follow the Uniswap v2 interface, we index the swap contracts in a new
chain.evm_swap_pairstable. the pair contracts emit a "Sync" event, which reports a contract's reserves, and the contract trades its two tokens in proportion to its reserves of the two tokens.we add a new configuration that specifies a collection of swap contracts identified by their "factory" contract plus a "reference" token. the relative token price estimate for a token is available when there is a swap pair contract for that token and the reference token or if the token is the reference token itself.
in this PR, we select illumineX swap and Wrapped ROSE (0x8Bc2B030b299964eEfb5e1e0b36991352E56D2D3) for Sapphire mainnet.