Add data about known addresses #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csillag
requested review from
Andrew7234,
mitjat,
pro-wh and
ptrus
as code owners
csillag
force-pushed
the
csillag/account-names
branch
from
c41f6b2 to
4ea5487
Compare
|
looking good. can we go without the .idea directory? |
csillag
force-pushed
the
csillag/account-names
branch
from
4ea5487 to
2d25c66
Compare
Ahh sorry, I have no idea how did it manage to sneak on board. Fixed. |
buberdds
reviewed
May 6, 2024
| @@ -0,0 +1 @@ | |||
| Add data about known addresses | |||
There was a problem hiding this comment.
Filename is incorrect. Requires manual tweak after running make changelog.
There was a problem hiding this comment.
oh shoot was it wrong number?
There was a problem hiding this comment.
yeah looks like it was created manually with some random number
There was a problem hiding this comment.
Sorry about that, I have no idea where that number came from.
There was a problem hiding this comment.
I think we can open a PR to rename it
#689
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Name known addresses in Explorer
Design is here.
Initial set of known addresses is here.
Create github repo with JSON, that contains key-value pair, contract:name
Auto deploy on master merge
@lubej:
This PR
We have decided to temporarily store the metadata about known addresses in the nexus repo, so that the frontends can pull this directly from github.
Later, hopefully, Nexus will serve this data via some API.