analyzer/runtime: limit total_{received,sent} to native denomination #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
changed the title
mitjat
force-pushed
the
mitjat/total-received-native-only2
branch
3 times, most recently
from
a6ee31c to
45189e2
Compare
mitjat
force-pushed
the
mitjat/total-received-native-only2
branch
3 times, most recently
from
2594c86 to
757f0e3
Compare
mitjat
commented
Mar 28, 2024
| @@ -14,7 +14,7 @@ staged_fragments="$(git diff --cached --name-only -- .changelog/*.md)" | |||
| # Re-wraps file $1 to 80 characters per line, using prettier, in-place. | |||
| rewrap() { | |||
| # Suppress the output of prettier, as it's overly verbose. Show only on errors. | |||
| prettier --no-config --no-editorconfig --prose-wrap always --print-width 80 --write "$f" >/tmp/prettier.out \ | |||
| prettier --no-config --no-editorconfig --prose-wrap always --print-width 78 --write "$f" >/tmp/prettier.out \ | |||
There was a problem hiding this comment.
unrelated, brings the autoformatter in line with the linter config
Andrew7234
approved these changes
Mar 29, 2024
mitjat
force-pushed
the
mitjat/total-received-native-only2
branch
from
757f0e3 to
22006dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pontusx is the first runtime where this makes a difference because it uses two separate SDK denominations. Before this PR, their stats got conflated in the total_received and total_sent metrics (i.e. the metric was a sum of the two SDK tokens, EUROe and TEST).
This PR is a no-op for other existing runtimes because the only SDK denomination they use is the native denomination.