api: log binned request latencies #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
approved these changes
Mar 27, 2024
| "request_id", requestID, | ||
| "time", time.Since(t), |
There was a problem hiding this comment.
😲 It was really unexpected to me that GCP just swallows the "time" field. Nice find. Just leaving a comment for posterity :)
Andrew7234
force-pushed
the
andrew7234/api-request-timings
branch
from
01dda2c to
134cfc6
Compare
Andrew7234
force-pushed
the
andrew7234/api-request-timings
branch
from
134cfc6 to
d2bd309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
The API layer logs requests but does not log query params:
nexus/api/middleware.go
Line 85 in 908a841
Add those, and add the duration of query, and add a field that categorizes the duration (e.g. <100ms, 100-300ms, 300-1000ms, >1000ms) so we can find expensive queries easily from the logs.
This PR
Adds query params and binned request latency to api logging. Also renames the existing
timefield tolatency.