Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak ci-lint workflow #662

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Tweak ci-lint workflow #662

merged 2 commits into from
Mar 24, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Mar 13, 2024 •
edited
Loading

  • prevent issues with dependabot PRs
  • limit towncrier check to pull_request event to fix an issue with failing workflow for merge commits (push event)
  • enable gitlint

@buberdds buberdds changed the title CI workflow lint fixes Tweak ci-lint workflow Mar 13, 2024
mitjat
mitjat reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I think we'll need to put in more effort for dependabot support. Happy to punt it to a later PR though if you prefer.

.github/workflows/ci-lint.yaml Show resolved Hide resolved
.github/workflows/ci-lint.yaml Show resolved Hide resolved
mitjat
mitjat approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michal!

@buberdds buberdds merged commit 12c4f8d into main Mar 24, 2024
14 checks passed
@buberdds buberdds deleted the mz/lint-tweaks branch March 24, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitjat mitjat mitjat approved these changes

@Andrew7234 Andrew7234 Awaiting requested review from Andrew7234 Andrew7234 is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buberdds @mitjat