-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement top part of token dashboard #623
Conversation
Deployed to Cloudflare Pages
|
5e3d9ec
to
6ae0fd3
Compare
@donouwens says:
There will be some updates, but what we have is already worth reviewing. |
45f8361
to
e1e7ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
e1e7ed4
to
941692e
Compare
b27ec14
to
9e00cc0
Compare
1a44550
to
a1e4606
Compare
3d223d1
to
40c8381
Compare
}) => { | ||
return ( | ||
<StyledCard> | ||
<CardHeader component="h5" title={title} sx={{ pb: 0, pl: 4, pt: 4 }} /> | ||
<StyledCardContent withContentPadding={withContentPadding}>{children}</StyledCardContent> | ||
{(badge || label) && ( | ||
{(badge || label || withConstantHeight) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(To avoid confusion when we bring in other tokens)
40c8381
to
6287ffe
Compare
(But disable it for now, since we are lacking the required information)
@donouwens approves the latest iteration of UI tweaks. |
ddcbbcc
to
791dce3
Compare
Apparently there was some mishap here around the various commits, because it looks the the version merged is not actually the final version; probably some commits were accidentally dropped as part of a force-push. Probably nothing major, just some small cleanups. Still looking. |
Guys, can you help me running some some analysis what happened here? Specifically, I'm looking at these events: In detail:
Now, of you look at the merge commit, it has this: The first parent is the last commit on the master branch, and the second parent comes from this branch. But it is not the last commit; it the one that have been superseeded and overwritten by the first event. (You can see the git commit hashes.) So basically, even though I have pushed the latest stuff, what has been merged is not the latest stuff, but the previous one. How is that even possible? |
I have restored the only missing change in #655, but I still don't understand what happend, and as a result, have lost a bit of trust in GitHub. |
The token dashboard is what we find when visiting
/:network:/:runtime:/token/:address:
, for example like this.This is different from the normal account / contract page. (Although they link to each other.)
The PR implements the top and middle part of the token dashboard. The bottom part (with multiple tabs) is coming later.
Designs:
Also, when displaying info about a contract
0x301879c8677e050f0f7104fe6a3059806Abb41C6
0x6Cb9750a92643382e020eA9a170AbB83Df05F30B