Show LongDataDisplay controls only when needed #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/longDataDisplay
branch
3 times, most recently
from
77bfeca to
bde5f75
Compare
lukaw3d
reviewed
Feb 22, 2024
buberdds
force-pushed
the
mz/longDataDisplay
branch
from
bde5f75 to
7036986
Compare
lukaw3d
approved these changes
Feb 22, 2024
buberdds
force-pushed
the
mz/longDataDisplay
branch
3 times, most recently
from
8621046 to
307e65e
Compare
buberdds
force-pushed
the
mz/longDataDisplay
branch
from
307e65e to
db730f9
Compare
buberdds
commented
Feb 23, 2024
| overflowWrap: 'anywhere', | ||
| display: '-webkit-box', | ||
| '-webkit-line-clamp': isExpanded ? 'none' : `${collapsedLinesNumber}`, // keep it as string to avoid MUI adding px |
There was a problem hiding this comment.
TODO: fix warning in console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack request
https://d05adace.oasis-explorer.pages.dev/mainnet/sapphire/tx/0xb0846c1ad0d3279fbf70eec6cf8a51a9141a746d8b26a55a24292f2c7c3b4d5c
https://d05adace.oasis-explorer.pages.dev/mainnet/sapphire/tx/0x84a24df4c7f8af3363df798155ffe57135861e69d0677c0148fbd3a9010f1acb
vs
https://explorer.dev.oasis.io/mainnet/sapphire/tx/0xb0846c1ad0d3279fbf70eec6cf8a51a9141a746d8b26a55a24292f2c7c3b4d5c