Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address formatting on empty account follow up #1061

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix address formatting on empty account follow up #1061

merged 2 commits into from
Dec 5, 2023

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Dec 4, 2023 •
edited
Loading

  • search broken due to useTransformToOasisAddress throwing on empty account
  • NFTs query broken due to the wrong contract address supplied

Resolves #1039 (comment)

@lubej lubej requested a review from buberdds December 4, 2023 15:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: d794cf39a86048cbbefc86c6aa09424ef0be201a
Status:✅ Deploy successful!
Preview URL: https://0997ed49.oasis-explorer.pages.dev

@lubej lubej force-pushed the ml/fix-address-formatting-on-empty-account-follow-up branch from 52de9e6 to def4565 Compare December 4, 2023 15:38
@lubej lubej requested a review from lukaw3d December 4, 2023 17:38
@lubej lubej force-pushed the ml/fix-address-formatting-on-empty-account-follow-up branch from def4565 to 13c1131 Compare December 5, 2023 07:32
@lubej lubej requested a review from lukaw3d December 5, 2023 07:33
@lubej lubej force-pushed the ml/fix-address-formatting-on-empty-account-follow-up branch from 13c1131 to d794cf3 Compare December 5, 2023 16:37
@lubej lubej enabled auto-merge December 5, 2023 16:40
@lubej lubej merged commit 196fd6d into master Dec 5, 2023
8 checks passed
@lubej lubej deleted the ml/fix-address-formatting-on-empty-account-follow-up branch December 5, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubej @lukaw3d