Handle new event types (placeholders) #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/new-event-types
branch
from
5a68b9a to
c8e18c5
Compare
Closed
csillag
changed the title
csillag
force-pushed
the
csillag/new-event-types
branch
from
c8e18c5 to
44ccd1c
Compare
lukaw3d
changed the title
csillag
force-pushed
the
csillag/new-event-types
branch
from
44ccd1c to
3ce1089
Compare
csillag
force-pushed
the
csillag/new-event-types
branch
2 times, most recently
from
cf02c2c to
729f16d
Compare
|
I have updated this PR to contain only that which has been left out of #906. |
This was referenced Sep 28, 2023
Merged
csillag
force-pushed
the
csillag/new-event-types
branch
2 times, most recently
from
db981de to
8e36291
Compare
csillag
force-pushed
the
csillag/new-event-types
branch
from
8e36291 to
67bc638
Compare
csillag
force-pushed
the
csillag/new-event-types
branch
2 times, most recently
from
ed9c760 to
76f7d9c
Compare
|
This has been refreshed again. |
csillag
changed the title
|
Please note that now there is data on the nexus DB which use these new types, and trying to explore that data leads to a crash in the current explorer. This PR fixes that. (But still, this is not ready for review, since it's intentionally a placeholder only, to avoid syntax errors and crashes) |
csillag
force-pushed
the
csillag/new-event-types
branch
from
76f7d9c to
fb06cd0
Compare
lukaw3d
approved these changes
Nov 7, 2023
Mostly just placeholders, in order to avoid syntax errors with latest API wrapper code. This is going to be flushed out later. (Custom icons, proper data fields displayed, etc.)
csillag
force-pushed
the
csillag/new-event-types
branch
from
fb06cd0 to
26e6507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove syntax errors introduced by the latest auto-generated API wrapper code in #888.
So this incorporated the new API code from that PR, and also the required fixes in other related code.
Please note that Handle new event types “consensus.Delegate”, “consensus.Undelegate” is still required; this code only adds placeholders, marked with TODO comments, where the actual new stuff will have to go. (Icons, data fields, etc.)