Fix charts by syncing with the latest tx_volume stats API changes #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
reviewed
Aug 22, 2023
Comment on lines
+21
to
+28
| window_size_seconds: fiveMinutesWindowSize, | ||
| window_step_seconds: fiveMinutesWindowSize, |
There was a problem hiding this comment.
Can you add comment about the difference
There was a problem hiding this comment.
Oh oops, hovering on them already explains the difference. It shows field docs because of satisfies { [duration in ChartDuration]: GetLayerStatsTxVolumeParams }
lukaw3d
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to oasisprotocol/nexus#477
Charts on prod are broken due to API change. There's draft PR, but Kristof is out this week. I don't think we need to switch date-fns functions from start* to end*. Output of FE grouping will be the same. We need to sync prop names and use both query params (window_size_seconds, window_step_seconds) for tx_volume.