-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Storybook issues #787
Fix Storybook issues #787
Conversation
Deployed to Cloudflare Pages
|
8be3e3d
to
aadc0a2
Compare
routeParams: { layer: 'emerald' }, | ||
const sapphireRoute = { | ||
routePath: '/:network/:layer', | ||
routeParams: { network: Network.mainnet, layer: Layer.sapphire }, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny thing, I think this is char by char the same as my (unfinished) https://github.com/oasisprotocol/explorer/pull/502/files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this obviously works, but I have very little idea about what the mockServiceWorker
does, or why does it do it. I think a little bit of in-line documentation (for the whole file, not the the individual functions) would go a long way.
aadc0a2
to
4f41f90
Compare
If we prefer not to store auto gen service worker file we can run |
Closes #501