Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storybook issues #787

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Fix Storybook issues #787

merged 3 commits into from
Aug 21, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Aug 3, 2023

Closes #501

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Deployed to Cloudflare Pages

Latest commit: 4f41f902ed1f194527cbcc04069811ffa0213341
Status:✅ Deploy successful!
Preview URL: https://5a21ca10.oasis-explorer.pages.dev

@buberdds buberdds force-pushed the mz/fixStorybook branch 7 times, most recently from 8be3e3d to aadc0a2 Compare August 3, 2023 12:55
@buberdds buberdds requested review from lukaw3d, csillag and lubej August 3, 2023 12:56
routeParams: { layer: 'emerald' },
const sapphireRoute = {
routePath: '/:network/:layer',
routeParams: { network: Network.mainnet, layer: Layer.sapphire },
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny thing, I think this is char by char the same as my (unfinished) https://github.com/oasisprotocol/explorer/pull/502/files.

Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this obviously works, but I have very little idea about what the mockServiceWorker does, or why does it do it. I think a little bit of in-line documentation (for the whole file, not the the individual functions) would go a long way.

@csillag csillag mentioned this pull request Aug 7, 2023
@buberdds
Copy link
Contributor Author

If we prefer not to store auto gen service worker file we can run npx msw init .storybook/public in yarn start-storybook and add a file to gitignore

@buberdds buberdds merged commit b7c0c23 into master Aug 21, 2023
@buberdds buberdds deleted the mz/fixStorybook branch August 21, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PageLayout stories are broken
2 participants