Add "Token Holders" tab to Token Dashboard #635
Conversation
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/token-dashboard-last-tab
branch
2 times, most recently
from
46bf6f6 to
e81c7e1
Compare
csillag
force-pushed
the
csillag/token-dashboard-last-tab
branch
2 times, most recently
from
950f482 to
3f1042d
Compare
csillag
force-pushed
the
csillag/token-dashboard-last-tab
branch
5 times, most recently
from
4840437 to
b3bfc8a
Compare
| }, | ||
| { | ||
| key: 'quantity', | ||
| content: t('tokens.totalSupplyValue', { value: fromBaseUnits(holder.balance, decimals) }), |
There was a problem hiding this comment.
Shouldn't we use RoundedBalance here for Quantity? Not sure about Percentage. for example
http://localhost:1234/mainnet/sapphire/token/0x4344919960B0196c512807eE2f3922302fFFE542/holders#holders
-- | --
1 | 0x3BA9F711C9808902f6a200d3715ba8a7e4D8b63f | 100 | 100.0000%
2 | 0x00000000000000000000000000000000000000ff | 0 | 0.0000%
we show 0 in the second row
There was a problem hiding this comment.
Shouldn't we use RoundedBalance here for Quantity?
OK done
There was a problem hiding this comment.
Not sure about Percentage. for example
http://localhost:1234/mainnet/sapphire/token/0x4344919960B0196c512807eE2f3922302fFFE542/holders#holders-- | -- 1 | 0x3BA9F711C9808902f6a200d3715ba8a7e4D8b63f | 100 | 100.0000% 2 | 0x00000000000000000000000000000000000000ff | 0 | 0.0000%we show 0 in the second row
I don't see the issue here. The percentage must obviously be a rounded value, so what else would anyone expect?
There was a problem hiding this comment.
Not sure what the issue is here; I think I agree here with @csillag
There was a problem hiding this comment.
OK, so I think we are good here.
There was a problem hiding this comment.
Shouldn't we use RoundedBalance here for Quantity?
Actually, the current implementation of RoundedBalance is not very good with bigger numbers.
I think vanilla i18n is actually better, for now..
| vanilla i18next | RoundedBalance |
|---|---|
 |
 |
csillag
force-pushed
the
csillag/token-dashboard-last-tab
branch
from
5751de4 to
949fd67
Compare
csillag
force-pushed
the
csillag/token-dashboard-last-tab
branch
7 times, most recently
from
aa85b8e to
2bc8ab3
Compare
csillag
force-pushed
the
csillag/token-dashboard-last-tab
branch
from
2bc8ab3 to
e33809a
Compare
csillag
force-pushed
the
csillag/token-dashboard-last-tab
branch
from
e33809a to
f347efa
Compare
This
is built on top of #634, andimplements the last missing tab, "Token Holders".Design is here.