Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update graph graphics #627

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Update graph graphics #627

merged 1 commit into from
Jun 29, 2023

Conversation

lubej
Copy link
Contributor

@lubej lubej commented Jun 29, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 38295b9cab6be80b97a8d2ba15617b165dcecb6c
Status:✅ Deploy successful!
Preview URL: https://70318e58.oasis-explorer.pages.dev

@lubej lubej force-pushed the ml/update-graph branch from 6eb7a9e to a336552 Compare June 29, 2023 09:31
@lubej lubej requested review from csillag, lukaw3d and buberdds June 29, 2023 09:31
@lubej lubej force-pushed the ml/update-graph branch from a336552 to 02403cf Compare June 29, 2023 09:32
@lubej lubej marked this pull request as ready for review June 29, 2023 09:32
buberdds
buberdds reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@buberdds buberdds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. ParaTimes circles are semi transparent and connecting lines below that layers are visible.

  2. Why Sapphire and Cipher look like they are enabled, but Emerald don't. This is more question to Don.

src/app/pages/HomePage/Graph/Graph/index.tsx
/>
<text x="150.5" y="39" fill={graphTheme.text} fontSize="4px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these svg paths that renders labels look blurry. Should we keep text nodes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to do this in next PR, as there are new animations, which affect the fonts as well. To keep PRs manageable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah Ok wasn't aware that we will have follow up updates 👍

@lubej lubej force-pushed the ml/update-graph branch from 02403cf to 38295b9 Compare June 29, 2023 10:36
@lubej lubej merged commit 0438ec0 into master Jun 29, 2023
@lubej lubej deleted the ml/update-graph branch June 29, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buberdds buberdds buberdds approved these changes

@csillag csillag Awaiting requested review from csillag csillag is a code owner

@lukaw3d lukaw3d Awaiting requested review from lukaw3d lukaw3d is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubej @buberdds