Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix info icon missing on mobile #601

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Jun 27, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Deployed to Cloudflare Pages

Latest commit: 349b34f51f4cb714d903276dc46e733e636d1fb4
Status:✅ Deploy successful!
Preview URL: https://5c336b2d.oasis-explorer.pages.dev

@lubej lubej requested review from lukaw3d, csillag and buberdds and removed request for lukaw3d June 27, 2023 11:40
@lubej lubej marked this pull request as ready for review June 27, 2023 12:15
Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making it more difficult to maintain and breaks things on landscape phone

Before After
before after

@lubej lubej force-pushed the ml/info-icon-missing-on-mobile branch from 976cbd0 to 8af1d95 Compare June 27, 2023 17:17
@lubej lubej changed the title Fix info icon missing on mobile and adjust height Fix info icon missing on mobile Jun 27, 2023
@lubej lubej force-pushed the ml/info-icon-missing-on-mobile branch 2 times, most recently from 6495288 to 14b9e2e Compare June 27, 2023 17:19
@lubej
Copy link
Collaborator Author

lubej commented Jun 27, 2023

This is making it more difficult to maintain and breaks things on landscape phone

Before After
before after

Ok. Reverting the height modifications. So only info icon is addressed.

@lubej lubej requested a review from lukaw3d June 27, 2023 17:21
@lukaw3d
Copy link
Member

lukaw3d commented Jun 27, 2023

Still can't reach the footer on landscape mode

@lukaw3d
Copy link
Member

lukaw3d commented Jun 27, 2023

Oh, you intentionally hid the footer on mobile?

@lubej
Copy link
Collaborator Author

lubej commented Jun 28, 2023

Oh, you intentionally hid the footer on mobile?

Right, this is expected behaviour.

@lubej lubej force-pushed the ml/info-icon-missing-on-mobile branch from 14b9e2e to 521bdfd Compare June 28, 2023 10:41
@lubej lubej enabled auto-merge June 28, 2023 10:43
@lubej lubej merged commit 958f734 into master Jun 28, 2023
@lubej lubej deleted the ml/info-icon-missing-on-mobile branch June 28, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants