Save Get Started button state #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
|
Should we merge the states? 🤔 |
|
Wait, was this planned? I thought "Explore" step was intentionally added to bring focus to search, and so that mobile users can normally scroll the screen, instead of drag event being intercepted by the graph area. |
So the feedback was that "Get Started" button was intrusive. It does make sense on desktop and mobile portrait mode(even though due to banners looks weird). But you are right, it might look weird on landscape mode on mobile. |
lubej
requested review from
lukaw3d and
buberdds
and removed request for
lukaw3d
lukaw3d
approved these changes
Jun 27, 2023
lubej
force-pushed
the
ml/ecosystem-onboarding-shouldnt-repeat
branch
from
b728e6b to
81a5a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.