Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap all long values in description list #571

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Wrap all long values in description list #571

merged 1 commit into from
Jun 21, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jun 20, 2023

Before After
localhost_1234_testnet_sapphire_tx_0x12106a139c9eb799f25b2fd3879827c23c737debefa63da8569560ba556e163c (1) localhost_1234_testnet_sapphire_tx_0x12106a139c9eb799f25b2fd3879827c23c737debefa63da8569560ba556e163c

@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 8d83c8975ceefb1f73c90a6130d016bde13470f2
Status:✅ Deploy successful!
Preview URL: https://8cec8aa8.oasis-explorer.pages.dev

@lukaw3d
Copy link
Member Author

lukaw3d commented Jun 20, 2023

@donouwens thoughts? this seems like a good fallback if mobile+tablet designs don't capture everything

@csillag
Copy link
Contributor

csillag commented Jun 21, 2023

Nice, but I don't get why Encrypted data looks like that (on the "before" image), since we already have wrapping enabled at

explorer/src/app/components/LongDataDisplay/index.tsx

Line 21 in 42e96f3

overflowWrap: 'anywhere',

And it does work, down to a specific width, and then stops working. I think that would be worth a separate fix.

csillag
csillag approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaw3d
Copy link
Member Author

lukaw3d commented Jun 21, 2023

@csillag And it does work, down to a specific width, and then stops working. I think that would be worth a separate fix.

Looks like it stops working at the width of tx hash (tx hash didn't have wrapping, and it extended the parent element width)

@csillag
Copy link
Contributor

csillag commented Jun 21, 2023

Changelog fragment seems to be missing

@lukaw3d lukaw3d merged commit 72e2e04 into master Jun 21, 2023
@lukaw3d lukaw3d deleted the lw/wrap-dl branch June 21, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csillag csillag csillag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaw3d @csillag