Prevent showing horizontal scrollbar on home page #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/homepageScroll
branch
2 times, most recently
from
417db9d to
6b5d160
Compare
Shouldn't we get rid of the vertical scroll here? The presence of the vertical scroll seems to be an error to me, since the main component is not taking the banner into account... |
|
Ah yeah that's another issue I will have to look at. |
Do we need both fixes? (Won't fixing that other issue automatically resolve this as well?) |
lubej
approved these changes
Jun 19, 2023
buberdds
force-pushed
the
mz/homepageScroll
branch
from
6b5d160 to
67552be
Compare
|
yeah, we will need both probably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported via Internal Launch Feedback.
For me scrollbar is visible always on home page
current
https://explorer.dev.oasis.io/Issue here is that home page layout is using
100vwwidth. Combo of100vw+ vertical scroll + no max width will cause horizontal scrolls to be visible.