Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Conform to EIP-3091 #530

Closed
1 task done
matevz opened this issue Jun 14, 2023 · 5 comments
Closed
1 task done

[Feature]: Conform to EIP-3091 #530

matevz opened this issue Jun 14, 2023 · 5 comments
Labels
feature New feature or request

Comments

@matevz
Copy link
Member

matevz commented Jun 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

SUMMARY

Add standardized explorer routes defined in EIP-3091 so we can hook it with Metamask and other Ethereum services

DESCRIPTION

See https://eips.ethereum.org/EIPS/eip-3091 for details. This is also a requirement, if we want to replace existing blockscout explorers in the official Ethereum chain list: https://github.com/ethereum-lists/chains

One way to do this is for example to use <BLOCK_EXPORER_URL> as https://explorer.stg.oasis.io/mainnet/sapphire and make aliases for:

  • block -> blocks,
  • tx -> transactions,
  • address -> account,
  • token/0x... -> address/0x... alias (for now until we get proper home page for the token)
@matevz matevz added the feature New feature or request label Jun 14, 2023
@csillag
Copy link
Contributor

csillag commented Jun 14, 2023

Why aliases, instead of simply changing those paths to mach the specs?

@matevz
Copy link
Member Author

matevz commented Jun 14, 2023

Why aliases, instead of simply changing those paths to mach the specs?

Sure, was just suggesting so we don't break anything that exists already ;)

@csillag
Copy link
Contributor

csillag commented Jun 14, 2023

Fortunately this has never been publicly advertised, so we don't have any contract (or expectation) to keep the current URLs stable.

@csillag
Copy link
Contributor

csillag commented Jun 14, 2023

I am unsure about the token part. About the rest, would this work? https://9da8918c.oasis-explorer.pages.dev/

@csillag
Copy link
Contributor

csillag commented Jun 15, 2023

I think this is mostly done now. The token support is not fully there, but we are building it up in small increments.

@csillag csillag closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants