Differentiate transaction amount and fee tickers #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses new fields amount_symbol and fee_symbol. Fixes Pontus-X transactions that transfer EUROe but pay fees in TEST. Pontus-X Devnet transaction: 40cd07b27f7edb42bbea128d473066a43877b12ba8be9f1253233dd79f283afc
Emerald transaction is missing both fields: 0xee5d8af74e955fffde2e801d0b400107b769458aa4cd9b297763dc9630ba0933
Deployed to Cloudflare Pages
|
buberdds
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1539, but for transaction fields
Transactions that transfer EUROe but pay fees in TEST
https://explorer.dev.oasis.io/testnet/pontusxdev/tx/40cd07b27f7edb42bbea128d473066a43877b12ba8be9f1253233dd79f283afc
Tx missing new fields still works
https://explorer.dev.oasis.io/mainnet/emerald/tx/0xee5d8af74e955fffde2e801d0b400107b769458aa4cd9b297763dc9630ba0933