Fix non-native event denominations #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until ba7990d36cf78b75cd5c1ea0666ce67fe41f04d5 all denominations were overwritten with native denomination. After it native denomination="" were displayed as "".
Deployed to Cloudflare Pages
|
buberdds
approved these changes
Sep 12, 2024
This was referenced Sep 12, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279 (comment)
Supersedes #1285 (comment)
Native denomination
https://explorer.dev.oasis.io/testnet/pontusxdev/tx/0xbc2e80b60af388ce9061f880968c940bc07500f69c622f11f2d50e4256952cd2
Non-native denomination
https://explorer.dev.oasis.io/testnet/pontusxdev/tx/40cd07b27f7edb42bbea128d473066a43877b12ba8be9f1253233dd79f283afc