Harden github workflow against injection #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/harden-gh-actions
branch
from
3f2c7c2 to
3adb610
Compare
lubej
approved these changes
Aug 12, 2024
| # Set git user email and name to match author of the last commit. | ||
| git config --local user.email "$(git log --pretty='%ae' -1)" | ||
| git config --local user.name "$(git log --pretty=format:'%an' -1)" | ||
| git add ${{ steps.vars.outputs.FILE_NAME }} | ||
| git add "$FILE_NAME" | ||
| git commit --amend --no-edit |
There was a problem hiding this comment.
Not sure who is the owner of git add here, but I would prefer it was another commit. As who ever the owner is, will be the co-author of the commit - and it would be just cleaner, to see which changes were made by this workflow - the downside is useless commit though.
There was a problem hiding this comment.
this only runs against renovate-bot's commit; and it is currently always failing. I'll leave it :D
lukaw3d
force-pushed
the
lw/harden-gh-actions
branch
from
d77184a to
9a33dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.