Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Storybook 8 #1389

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Migrate to Storybook 8 #1389

merged 4 commits into from
Apr 26, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Apr 24, 2024

  • mockService is autogenerated file
  • one of our test relies on Storybook 7 dep, so needed to add node fetch types to our package.json

side note: Storybook does not support Parcel builds, so moving to Vite will reduce node_module

https://github.com/storybookjs/storybook/tree/next/code/frameworks
https://github.com/parcel-bundler/parcel/issues/8668

Copy link

github-actions bot commented Apr 24, 2024

Deployed to Cloudflare Pages

Latest commit: 7c2cf3bbb2bd112319a7fb7784057dc8c60a507b
Status:✅ Deploy successful!
Preview URL: https://5e19754f.oasis-explorer.pages.dev

@lubej
Copy link
Collaborator

lubej commented Apr 26, 2024

side note: Storybook does not support Parcel builds, so moving to Vite will reduce node_module

But Storybook relies on Webpack? At least on first glance at the config. Don't see a connection with Vite here, unless it supports vite plugin.

@lukaw3d
Copy link
Member

lukaw3d commented Apr 26, 2024

Yep, supports vite too

@buberdds buberdds merged commit 9f4eca9 into master Apr 26, 2024
8 checks passed
@buberdds buberdds deleted the mz/storybook branch April 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants