Fetch balances from Oasis gRPC instead of Web3 RPC #1384
Conversation
Deployed to Cloudflare Pages
|
| return { | ||
| balance: oasis.quantity.toBigInt(amount).toString(), | ||
| token_symbol: oasis.misc.toStringUTF8(denomination) || getTokensForScope(scope)[0].ticker, | ||
| token_decimals: paraTimesConfig[scope.layer].decimals, // TODO: differentiate by token |
There was a problem hiding this comment.
That doesn't look right, if this is querying ERC-20 tokens as well, each of the ERC-20 token, can have custom decimals specified. So defaulting to paratime decimals here, is wrong.
There was a problem hiding this comment.
It's only querying e.g. TEST and EUROe; evm_balances are a different field in Nexus API.
But we don't differentiate decimals between TEST and EUROe - related: #1265 (comment)
There was a problem hiding this comment.
Ok, I verified that both Ocean and EUROe use 18 decimals places, so coincidentally this works as expected.
Looking at the documentation at https://docs.pontus-x.eu/docs/Development/quick_start#setup-metamask the native token has been renamed to GX @csillag are we aware of this?
Scratch the above, was looking at the wrong documentation. The right documentation is linked here: https://docs.pontus-x.eu/docs/ParaTime/quick_start#setup-metamask
| .map(token => { | ||
| return { | ||
| ...token, | ||
| balance: fromBaseUnits(token.balance, token.token_decimals), | ||
| } | ||
| }) |
There was a problem hiding this comment.
This is iterating twice over an array, for no good reason. This should happen in the previous map.
There was a problem hiding this comment.
I prefer this, and it mirrors
explorer/src/oasis-nexus/api.ts
Lines 361 to 366 in 2607980
(I also think https://github.com/oasisprotocol/explorer-frontend/blob/26079807ff9a4e91cc42d106d75a0c824533caba/src/oasis-nexus/api.ts#L709-L752 should be split into multiple iterations over an array)
There was a problem hiding this comment.
I know it is not a large array, but for me it makes no sense, to iterate over the same array multiple times.
This fixes wrong balance on non-EVM addresses like fee accumulator. It also gets balances of all tokens (e.g. TEST and EUROe on Pontus-X). And it can start the request before Nexus responds with address_eth.
lukaw3d
force-pushed
the
lw/rpc-refactor
branch
from
2607980 to
595ceca
Compare
Fixes #1367
Differences in behaviour:
Related to #1073 #1338 #1374 #1318 (comment)