Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pontus-X as a hidden layer #1245

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add Pontus-X as a hidden layer #1245

merged 4 commits into from
Feb 13, 2024

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Feb 11, 2024 •
edited
Loading

  • It's not shown on the landing page graph
  • It's not listed in the layer selector
  • It can be accessed using the correct URL
  • Currently all the data is mock data, coming for Sapphire

There is no nexus support yet, so all requests are sent to Sapphire.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: feae7fd44aff889e9aad7fe3456d995d2ca10c73
Status:✅ Deploy successful!
Preview URL: https://1d32fa10.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/add-pontusx branch 2 times, most recently from 17d6258 to 129c915 Compare February 11, 2024 17:29
@csillag csillag marked this pull request as ready for review February 11, 2024 17:31
@csillag csillag mentioned this pull request Feb 11, 2024
Closed
buberdds
buberdds reviewed Feb 12, 2024
View reviewed changes
src/oasis-nexus/v1.yaml Outdated Show resolved Hide resolved
src/types/layers.ts Show resolved Hide resolved
src/app/components/LayerPicker/LayerDetails.tsx Outdated Show resolved Hide resolved
src/app/components/Search/search-utils.ts Show resolved Hide resolved
src/app/pages/HomePage/Graph/Graph/graph-utils.ts Show resolved Hide resolved
src/app/pages/ParatimeDashboardPage/LearningMaterials.tsx Outdated Show resolved Hide resolved
src/app/utils/externalLinks.ts Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/add-pontusx branch 3 times, most recently from 3c413a7 to 3ef4428 Compare February 13, 2024 01:57
@csillag
Add Pontus-X as a hidden layer
d668a43 
- It's not shown on the landing page graph
- It's not listed in the layer selector
- It can be accessed using the correct URL
- Currently all the data is mock data, coming for Sapphire
@csillag
Simplify: remove double function
429b6fa
@csillag csillag force-pushed the csillag/add-pontusx branch from e105e04 to 0edf35b Compare February 13, 2024 02:06
@csillag csillag force-pushed the csillag/add-pontusx branch from 0edf35b to feae7fd Compare February 13, 2024 02:09
@csillag csillag requested review from buberdds and lubej February 13, 2024 02:17
lubej
lubej approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/app/components/Search/search-utils.ts Show resolved Hide resolved
@csillag csillag merged commit 4f52843 into master Feb 13, 2024
8 checks passed
@csillag csillag deleted the csillag/add-pontusx branch February 13, 2024 10:27
lukaw3d
lukaw3d reviewed Feb 15, 2024
View reviewed changes
src/config.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubej lubej lubej approved these changes

@lukaw3d lukaw3d lukaw3d left review comments

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csillag @buberdds @lukaw3d @lubej