Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade orval and start using urlEncodeParameters #1097

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Dec 14, 2023

No description provided.

Copy link

github-actions bot commented Dec 14, 2023

Deployed to Cloudflare Pages

Latest commit: 04d0181d6e8943f3f246b577b38f92b546bfc544
Status:✅ Deploy successful!
Preview URL: https://0e8d6bc4.oasis-explorer.pages.dev

optionalDependencies:
fsevents "~2.3.3"

vitest@^0.34.6:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment in Renovate PR but their last deploy adds tons of orval dev deps to our node modules (vite, rollup, esbuild etc).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. did you comment anywhere upstream?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, merging the fix just missed the release of v6.24.0 :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its included

@lukaw3d lukaw3d merged commit 44e06b0 into master Feb 6, 2024
8 checks passed
@lukaw3d lukaw3d deleted the lw/encode-orval branch February 6, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants