Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

Fold in more planned upstream changes #11

Closed
4 tasks done
Yawning opened this issue Oct 28, 2019 · 1 comment
Closed
4 tasks done

Fold in more planned upstream changes #11

Yawning opened this issue Oct 28, 2019 · 1 comment
Assignees
Labels
p:1 Priority: core feature

Comments

@Yawning
Copy link
Contributor

Yawning commented Oct 28, 2019

In keeping with the "drop-in replacement" design goal, there are additional forthcoming upstream changes that need to be folded in.

32670 includes the RFC 8422 check for contributory behavior. There's some dissenting opinions about how useful this is (See section 12 of the Noise protocol spec for one).

The second issue, despite it's title at the time of this writing, applies to doing the appropriate checks in the ed25519 code.

These should wait till the relevant changes are merged upstream, support for ed25519ctx/ph was merged early because we were thinking about using it.

@Yawning Yawning added the p:1 Priority: core feature label Oct 28, 2019
@Yawning Yawning self-assigned this Oct 28, 2019
@Yawning Yawning changed the title Fold in more upstream behavior changes as they solidify Fold in more planned upstream changes Oct 28, 2019
@Yawning
Copy link
Contributor Author

Yawning commented Nov 2, 2020

We now reject low order points at verification time unless configured otherwise. Calling this done.

@Yawning Yawning closed this as completed Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p:1 Priority: core feature
Projects
None yet
Development

No branches or pull requests

1 participant