Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify where in $apply parameter aliases are allowed #1989

Open
HeikoTheissen opened this issue Sep 5, 2024 · 4 comments · May be fixed by #2003
Open

Clarify where in $apply parameter aliases are allowed #1989

HeikoTheissen opened this issue Sep 5, 2024 · 4 comments · May be fixed by #2003
Assignees
Labels
Data Aggregation Extension for Data Aggregation

Comments

@HeikoTheissen
Copy link
Contributor

The Data Aggregation spec is mostly silent on this point.

  • According to the core spec, they are allowed in functions like Aggregation.isancestor.
  • Since the filter or orderby transformations are defined in terms of the corresponding system query options, they are allowed here.
  • Should be analogous for compute, but is not, because this speaks only of a "common expression".
  • What about topcount etc.?
@HeikoTheissen HeikoTheissen self-assigned this Sep 5, 2024
@HeikoTheissen HeikoTheissen added the Data Aggregation Extension for Data Aggregation label Sep 5, 2024
@ralfhandl
Copy link
Contributor

Re compute:

  • commonExpr includes firstMemberExpr
  • which includes inscopeVariableExpr
  • which includes parameterAlias

Parameter alias are thus allowed, better add a test case if one doesn't exist yet.

@ralfhandl
Copy link
Contributor

Re topcount etc.:

  • if they allow commonExpr (which topcount does), they allow parameter aliases

Again a test case would be helpful if one doesn't exist yet.

@HeikoTheissen
Copy link
Contributor Author

Seems the ABNF is a better source here than the specification.

@ralfhandl
Copy link
Contributor

We may want to change that.

@HeikoTheissen HeikoTheissen linked a pull request Sep 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Aggregation Extension for Data Aggregation
Projects
Status: Open
Development

Successfully merging a pull request may close this issue.

2 participants