This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-207] fix issues found from aggregate unit tests #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuechendi @zhouyuan hi, I made some fixes for the issues found in aggregate, could you help take a review? We can have more discussions on this pr. |
|
|
zhouyuan
added a commit
that referenced
this pull request
May 13, 2021
* [NSE-262] fix remainer loss in decimal divide (#263) * fix decimal divide int issue * correct cpp uts * use const reference Co-authored-by: Yuan <[email protected]> Co-authored-by: Yuan <[email protected]> * [NSE-261] ArrowDataSource: Add S3 Support (#270) Closes #261 * [NSE-196] clean up configs in unit tests (#271) * remove testing config * remove unused configs * [NSE-265] Reserve enough memory before UnsafeAppend in builder (#266) * change the UnsafeAppend to Append * fix buffer builder in shuffle shuffle builder use UnsafeAppend API for better performance. it tries to reserve enough space based on results of last recordbatch, this maybe not buggy if there's a dense recordbatch after a sparse one. this patch adds below fixes: - adds Reset() after Finish() in builder - reserve length for offset_builder in binary builder A further clean up on the reservation logic should be needed. Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Yuan Zhou <[email protected]> * [NSE-274] Comment to trigger tpc-h RAM test (#275) Closes #274 * bump cmake to 3.16 (#281) Signed-off-by: Yuan Zhou <[email protected]> * [NSE-276] Add option to switch Hadoop version (#277) Closes #276 * [NSE-119] clean up on comments (#288) Signed-off-by: Yuan Zhou <[email protected]> * [NSE-206]Update installation guide and configuration guide. (#289) * [NSE-206]Update installation guide and configuration guide. * Fix numaBinding setting issue. & Update description for protobuf * [NSE-206]Fix Prerequisite and Arrow Installation Steps. (#290) * [NSE-245]Adding columnar RDD cache support (#246) * Adding columnar RDD cache support Signed-off-by: Chendi Xue <[email protected]> * Directly save reference, only convert to Array[Byte] when calling by BlockManager Signed-off-by: Chendi Xue <[email protected]> * Add DeAllocator to construction to make sure this instance will be released once it be deleted by JVM Signed-off-by: Chendi Xue <[email protected]> * Delete cache by adding a release in InMemoryRelation Since unpersist only delete RDD object, seems our deAllocator wasn't being called along Now we added a release function in InMemoryRelation clearCache() func, may need to think a new way for 3.1.0 Signed-off-by: Chendi Xue <[email protected]> * [NSE-207] fix issues found from aggregate unit tests (#233) * fix incorrect input in Expand * fix empty input for aggregate * fix only result expressions * fix empty aggregate expressions * fix res attr not found issue * refine * fix count distinct with null * fix groupby of NaN, -0.0 and 0.0 * fix count on mutiple cols with null in WSCG * format code * support normalize NaN and 0.0 * revert and update * support normalize function in WSCG * [NSE-206]Update documents and License for 1.1.0 (#292) * [NSE-206]Update documents and remove duplicate parts * Modify documents by comments * [NSE-293] fix unsafemap with key = '0' (#294) Signed-off-by: Yuan Zhou <[email protected]> * [NSE-257] fix multiple slf4j bindings (#291) * [NSE-297] Disable incremental compiler in GHA CI (#298) Closes #297 * [NSE-285] ColumnarWindow: Support Date input in MAX/MIN (#286) Closes #285 * [NSE-304] Upgrade to Arrow 4.0.0: Change basic GHA TPC-H test target OAP Arrow branch (#306) * [NSE-302] remove exception (#303) * [NSE-273] support spark311 (#272) * support spark 3.0.2 Signed-off-by: Yuan Zhou <[email protected]> * update to use spark 302 in unit tests Signed-off-by: Yuan Zhou <[email protected]> * support spark 311 Signed-off-by: Yuan Zhou <[email protected]> * fix Signed-off-by: Yuan Zhou <[email protected]> * fix missing dep Signed-off-by: Yuan Zhou <[email protected]> * fix broadcastexchange metrics Signed-off-by: Yuan Zhou <[email protected]> * fix arrow data source Signed-off-by: Yuan Zhou <[email protected]> * fix sum with decimal Signed-off-by: Yuan Zhou <[email protected]> * fix c++ code Signed-off-by: Yuan Zhou <[email protected]> * adding partial sum decimal sum Signed-off-by: Yuan Zhou <[email protected]> * fix hashagg in wscg Signed-off-by: Yuan Zhou <[email protected]> * fix partial sum with number type Signed-off-by: Yuan Zhou <[email protected]> * fix AQE shuffle copy Signed-off-by: Yuan Zhou <[email protected]> * fix shuffle redudant reat Signed-off-by: Yuan Zhou <[email protected]> * fix rebase Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * avoid unecessary fallbacks Signed-off-by: Yuan Zhou <[email protected]> * on-demand scala unit tests Signed-off-by: Yuan Zhou <[email protected]> * clean up Signed-off-by: Yuan Zhou <[email protected]> * [NSE-311] Build reports errors (#312) Closes #311 * [NSE-257] fix the dependency issue on v2 Co-authored-by: Rui Mo <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: JiaKe <[email protected]> Co-authored-by: Wei-Ting Chen <[email protected]> Co-authored-by: Chendi.Xue <[email protected]> Co-authored-by: Hong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fixes some issues in: #207
depends on: oap-project/arrow#11
How was this patch tested?
verified on TPC-DS v1