Add package & executable parameter to container #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to use a component container implementation other than `component_container`, such as `component_container_isolated` and `component_container_mt`.
oKermorgant
requested changes
Mar 22, 2022
| @@ -410,7 +410,7 @@ def group(self, ns=None, if_arg=None, unless_arg=None, if_condition=None, unless | |||
|
|
|||
|
|
|||
| @contextmanager | |||
| def container(self, name, namespace = '', existing = False, **container_args): | |||
| def container(self, name, namespace = '', existing = False, package='rclcpp_components', executable='component_container', **container_args): | |||
There was a problem hiding this comment.
This is a nice idea. Can you update the Readme so that is also references the fact we can pick the composition package?
There was a problem hiding this comment.
Readme has been updated already.
|
Hi, Good idea and thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to use a component container implementation other than
component_container, such ascomponent_container_isolatedandcomponent_container_mt.