Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer Nomination: jhmueller-huawei #123

Closed
jhmueller-huawei opened this issue Feb 28, 2023 · 7 comments
Closed

Reviewer Nomination: jhmueller-huawei #123

jhmueller-huawei opened this issue Feb 28, 2023 · 7 comments

Comments

@jhmueller-huawei
Copy link
Contributor

jhmueller-huawei commented Feb 28, 2023

Nomination Guidelines

Reviewer Nomination Requirements
6+ contributions successfully submitted to O3DE

  1. Using a multicontext version of glad to prepare for multi GPU support. o3de#10118
  2. Adopt BinPackArguments: false in .clang-format. o3de#10141
  3. Fixed a unused variable compilation error. o3de-atom-sampleviewer#472
  4. Compile fix for enabled AZ_RPI_ENABLE_PASS_DEBUGGING. o3de#11700
  5. Adding ScopeAttachmentUsage::Indirect to work. o3de#11701
  6. Possibility to initialize multiple RHI devices. o3de#14644
  7. Remove ImageSubresourceLayoutPlaced. o3de#14719

100+ lines of code changed across all contributions submitted to O3DE

The first commit already manages that.

2+ O3DE Reviewers or Maintainers that support promotion from Contributor to Reviewer

I hope to get the support of @moudgils and @thefranke.

Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month


Reviewer/Maintainer Nomination

Fill out the template below including nominee GitHub user name, desired role and personal GitHub profile

I would like to nominate: jhmueller-huawei, to become a Reviewer/Maintainer on behalf of sig-graphics-audio. I verify that they have fulfilled the prerequisites for this role.

Reviewers & Maintainers that support this nomination should comment in this issue.

@thefranke
Copy link

I support this nomination. Joerg is working on some rather large code chunks in the RHI and has gathered extensive knowledge, so they will make a great reviewer.

@rgba16f
Copy link
Contributor

rgba16f commented Feb 28, 2023

I support this nomination.

@moudgils
Copy link
Contributor

I support the nomination

1 similar comment
@galibzon
Copy link
Collaborator

I support the nomination

@thefranke
Copy link

Can we close this ticket @moudgils ?

@moudgils
Copy link
Contributor

moudgils commented Jan 4, 2024

Closing this issue with the assumption that jhmuller is added to reviewer list

@moudgils moudgils closed this as completed Jan 4, 2024
@jhmueller-huawei
Copy link
Contributor Author

Yes, I've been added in the meantime :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants