Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ROS2LidarSensorComponent and ROS2Lidar2DSensorComponent #435

Closed
jhanca-robotecai opened this issue Jul 27, 2023 · 1 comment
Closed

Refactor ROS2LidarSensorComponent and ROS2Lidar2DSensorComponent #435

jhanca-robotecai opened this issue Jul 27, 2023 · 1 comment
Assignees
@Antoni-Robotec
Labels
good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/enhancement Enhancement to an existing feature. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation

Comments

@jhanca-robotecai
Copy link
Contributor

There are two lidar sensor components available in ROS2 Gem: ROS2LidarSensorComponent and ROS2Lidar2DSensorComponent. Both components share most of the configuration and implementation, which is duplicated in two separate classes. Refactor the code to make it more readable and less duplicated.

Please note PR #433, which modifies the implementation. This PR should be merged first to reduce the rebase/merge overhead.
@jhanca-robotecai jhanca-robotecai mentioned this issue Jul 27, 2023
Merged
@jhanca-robotecai jhanca-robotecai added kind/enhancement Enhancement to an existing feature. good-first-issue Issue ready for a new contributor according to the help wanted guidelines. priority/minor Lowest priority. Work that may be scheduled labels Jul 27, 2023
@adamdbrw adamdbrw added priority/major Major priority. Work that should be handled after all blocking and critical work is done. and removed priority/minor Lowest priority. Work that may be scheduled labels Aug 1, 2023
@byrcolin byrcolin added the sig/simulation Categorizes an issue or PR as relevant to SIG Simulation label Aug 1, 2023
@Antoni-Robotec Antoni-Robotec self-assigned this Aug 16, 2023
@Antoni-Robotec Antoni-Robotec mentioned this issue Aug 21, 2023
Merged
@arturkamieniecki
Copy link
Contributor

Closed as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Antoni-Robotec Antoni-Robotec

Labels
good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/enhancement Enhancement to an existing feature. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@adamdbrw @byrcolin @arturkamieniecki @jhanca-robotecai @Antoni-Robotec