VerificationKey toJson and fromJson are doing different encodings

[rpanic]

The following code throws an error

const json = VerificationKey.toJSON(vk);
const decoded = VerificationKey.fromJSON(json);

The reason for this is that toJSON returns only the data field as a string and omits the hash, but fromJSON doesn't account for that

[mitschabaude]

I wonder why we did toJSON() that way, can't think of a good reason 🤔
The transaction types include both the hash and data for verification keys.

[mitschabaude]

I think you can probably just change .toJSON() to include the hash

[rpanic]

I assume its because the hash is just a pure computation away from the data itself. So one could implement fromJson in a way that computes that hash out of the data.
I can create a PR if you want, but on my side I've fixed it by just doing manual serialization including the hash

[45930]

@rpanic I will give you a gold star if you open the PR yourself :). I really appreciate your contributions!