swagger: make WithStatus ignore 0s

swagger/response.go

@@ -28,7 +28,10 @@ func NewErrorResponse(err error) *ErrorResponse {
 
 // WithStatus creates a new copy of ErrorResponse using the given status.
 func (r *ErrorResponse) WithStatus(status int) *ErrorResponse {
-	return &ErrorResponse{Message: r.Message, status: status}
+	if status > 0 {
+		return &ErrorResponse{Message: r.Message, status: status}
+	}
+	return r
 }
 
 // Error returns the underlying error message.

swagger/response_test.go

@@ -37,6 +37,21 @@ func TestErrorResponseCustomStatus(t *testing.T) {
 	}
 }
 
+func TestErrorResponseZeroStatus(t *testing.T) {
+	internalError := errors.New("something went wrong")
+	errResp := NewErrorResponse(internalError).WithStatus(0)
+	code, data, err := errResp.Result()
+	if code != http.StatusInternalServerError {
+		t.Errorf("Wrong error code. Want %d. Got %d", http.StatusInternalServerError, code)
+	}
+	if data != nil {
+		t.Errorf("Unexpected non-nil data: %#v", data)
+	}
+	if err != errResp {
+		t.Errorf("Wrong error returned. Want %#v. Got %#v", errResp, err)
+	}
+}
+
 func TestErrorResponsErrorInterface(t *testing.T) {
 	var err error
 	msg := "something went wrong"