You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling the standard UIViewController method -dismissViewControllerAnimated:completion: leaves the photos view controller in a bad state. This method should work: introducing a view controller which requires a custom method for dismissal breaks inheritance, is poor practice, and feels wrong.
The correct fix, we believe, is to dig in and figure out why this method doesn't work, not to expose an internal implementation detail as proposed by #72 and #96.
If we investigate this and find that this proposed fix is infeasible, we'll reopen & reevaluate the relevant issue & PR, plus @bcapps's comment in #96 (comment) .
The text was updated successfully, but these errors were encountered:
Calling the standard
UIViewController
method-dismissViewControllerAnimated:completion:
leaves the photos view controller in a bad state. This method should work: introducing a view controller which requires a custom method for dismissal breaks inheritance, is poor practice, and feels wrong.The correct fix, we believe, is to dig in and figure out why this method doesn't work, not to expose an internal implementation detail as proposed by #72 and #96.
For additional discussion see #72 (comment) .
If we investigate this and find that this proposed fix is infeasible, we'll reopen & reevaluate the relevant issue & PR, plus @bcapps's comment in #96 (comment) .
The text was updated successfully, but these errors were encountered: