Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-dismissViewControllerAnimated:completion: doesn't work #109

Closed
cdzombak opened this issue Jan 4, 2016 · 1 comment
Closed

-dismissViewControllerAnimated:completion: doesn't work #109

cdzombak opened this issue Jan 4, 2016 · 1 comment
Labels

Comments

@cdzombak
Copy link
Contributor

cdzombak commented Jan 4, 2016

Calling the standard UIViewController method -dismissViewControllerAnimated:completion: leaves the photos view controller in a bad state. This method should work: introducing a view controller which requires a custom method for dismissal breaks inheritance, is poor practice, and feels wrong.

The correct fix, we believe, is to dig in and figure out why this method doesn't work, not to expose an internal implementation detail as proposed by #72 and #96.

For additional discussion see #72 (comment) .

If we investigate this and find that this proposed fix is infeasible, we'll reopen & reevaluate the relevant issue & PR, plus @bcapps's comment in #96 (comment) .

@cdzombak cdzombak added the bug label Jan 4, 2016
This was referenced Jan 4, 2016
@cdzombak
Copy link
Contributor Author

cdzombak commented Jan 4, 2016

may, just possibly, be related to #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant