Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing "https" #19

Open
jumpjack opened this issue Mar 7, 2023 · 3 comments
Open

Missing "https" #19

jumpjack opened this issue Mar 7, 2023 · 3 comments

Comments

@jumpjack
Copy link

jumpjack commented Mar 7, 2023

Missing "https" in this and next line:

Leaflet.GeotagPhoto/examples/camera.html

Line 11 in 40340db

<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/highlight.js/9.8.0/styles/default.min.css">

@bertspaan
Copy link
Collaborator

// means use the same protocol as the web page itself. When I try https://spacetime.nypl.org/Leaflet.GeotagPhoto/examples/camera.html, everything seems to work. Can you try that?

@jumpjack
Copy link
Author

jumpjack commented Mar 7, 2023

Locally on my PC it does not work (404 not found).

@bertspaan
Copy link
Collaborator

That's strange, here it works, in every browser, on my laptop as well as my Android phone. Maybe it's some HTTPS certificate

issue. Unfortunately, I can't solve that, or change the repo - I no longer work at NYPL and I don't have access to this repo anymore.

The only thing that I could do is fork the repo, fix all errors, and point the URL on Leaflet's plugin web page to the new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bertspaan @jumpjack