Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect path in resources/credentials.ts #605

Closed
paulw11 opened this issue Nov 19, 2024 · 1 comment
Closed

Incorrect path in resources/credentials.ts #605

paulw11 opened this issue Nov 19, 2024 · 1 comment
Labels

Comments

@paulw11
Copy link

paulw11 commented Nov 19, 2024

Describe the bug
The api paths used in the resources/credentials.ts file incorrectly specify /v3/credentials/${provider}/creds when they should be /v3/connectors/${provider}/creds

This results in a 404 response code and a message from the SDK -

Unrecognized request URL. Please see https://developer.nylas.com/docs/api/v3/ecc/ or we can help at https://support.nylas.com/

To Reproduce
Some steps involved to reproduce the bug and any code samples you can share.

const requestBody: CreateMicrosoftCredentialRequest = {
      name,
      credentialType: CredentialType.ADMINCONSENT,
      credentialData: {
        clientId,
        clientSecret,
        tenant
      }
    }

    const credential = await nylasApi.connectors.credentials.create({ provider: 'microsoft', requestBody })

Expected behavior
A credential should be created

SDK Version:
7.6.2

@paulw11 paulw11 added the bug label Nov 19, 2024
This was referenced Nov 28, 2024
@SubashPradhan
Copy link
Contributor

The fix has been released on v7.7.2. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants