Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic for recording cron stats up into app layer #380

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.31%. Comparing base (add424d) to head (527b342).

Files with missing lines Patch % Lines
core/tasks/cron.go 85.00% 3 Missing and 3 partials ⚠️
utils/crons/cron.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   62.27%   62.31%   +0.03%     
==========================================
  Files         195      195              
  Lines       13809    13807       -2     
==========================================
+ Hits         8600     8604       +4     
+ Misses       4297     4291       -6     
  Partials      912      912              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 6a72504 into main Dec 12, 2024
5 checks passed
@rowanseymour rowanseymour deleted the crons_rework branch December 12, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants