diff --git a/src/core/labeling/qgslabelingengine.cpp b/src/core/labeling/qgslabelingengine.cpp index cab5554ded86..714462d56198 100644 --- a/src/core/labeling/qgslabelingengine.cpp +++ b/src/core/labeling/qgslabelingengine.cpp @@ -720,7 +720,7 @@ void QgsLabelingEngine::drawLabelCandidateRect( pal::LabelPosition *lp, QgsRende drawLabelCandidateRect( lp->nextPart(), context, xform, candidates ); } -void QgsLabelingEngine::drawLabelMetrics( pal::LabelPosition *label, QgsMapToPixel xform, QgsRenderContext &context, const QPointF &renderPoint ) +void QgsLabelingEngine::drawLabelMetrics( pal::LabelPosition *label, const QgsMapToPixel &xform, QgsRenderContext &context, const QPointF &renderPoint ) { QPainter *painter = context.painter(); if ( !painter ) diff --git a/src/core/labeling/qgslabelingengine.h b/src/core/labeling/qgslabelingengine.h index bb1ddda759c9..cd1568813e13 100644 --- a/src/core/labeling/qgslabelingengine.h +++ b/src/core/labeling/qgslabelingengine.h @@ -439,7 +439,7 @@ class CORE_EXPORT QgsLabelingEngine * * \see drawLabelCandidateRect() */ - static void drawLabelMetrics( pal::LabelPosition *label, QgsMapToPixel xform, QgsRenderContext &context, const QPointF &renderPoint ); + static void drawLabelMetrics( pal::LabelPosition *label, const QgsMapToPixel &xform, QgsRenderContext &context, const QPointF &renderPoint ); protected: void processProvider( QgsAbstractLabelProvider *provider, QgsRenderContext &context, pal::Pal &p ); diff --git a/src/core/pointcloud/qgscopcpointcloudindex.cpp b/src/core/pointcloud/qgscopcpointcloudindex.cpp index c50a5a395b21..c8a66af57992 100644 --- a/src/core/pointcloud/qgscopcpointcloudindex.cpp +++ b/src/core/pointcloud/qgscopcpointcloudindex.cpp @@ -307,7 +307,7 @@ QgsPointCloudStatistics QgsCopcPointCloudIndex::metadataStatistics() const { if ( ! mStatistics ) { - QByteArray statisticsEvlrData = fetchCopcStatisticsEvlrData(); + const QByteArray statisticsEvlrData = fetchCopcStatisticsEvlrData(); if ( statisticsEvlrData.isEmpty() ) mStatistics = QgsPointCloudIndex::metadataStatistics(); else diff --git a/src/core/pointcloud/qgspointcloudindex.h b/src/core/pointcloud/qgspointcloudindex.h index 92df034b21a0..2c038a5fe441 100644 --- a/src/core/pointcloud/qgspointcloudindex.h +++ b/src/core/pointcloud/qgspointcloudindex.h @@ -162,9 +162,16 @@ class CORE_EXPORT QgsPointCloudNode * Constructs new node object. Should only be called by QgsPointCloudIndex::getNode(). * Bounds should always be computed by QgsPointCloudNode::bounds(). */ - QgsPointCloudNode( QgsPointCloudNodeId id, qint64 pointCount, - QList childIds, float error, QgsBox3D bounds ) - : mId( id ), mPointCount( pointCount ), mChildIds( childIds ), mError( error ), mBounds( bounds ) + QgsPointCloudNode( const QgsPointCloudNodeId &id, + qint64 pointCount, + const QList &childIds, + float error, + const QgsBox3D &bounds ) + : mId( id ) + , mPointCount( pointCount ) + , mChildIds( childIds ) + , mError( error ) + , mBounds( bounds ) { } //! Returns node's ID (unique in index) diff --git a/src/core/pointcloud/qgspointcloudstatistics.cpp b/src/core/pointcloud/qgspointcloudstatistics.cpp index 402384b2958e..c53e7cabcb81 100644 --- a/src/core/pointcloud/qgspointcloudstatistics.cpp +++ b/src/core/pointcloud/qgspointcloudstatistics.cpp @@ -165,7 +165,7 @@ QByteArray QgsPointCloudStatistics::toStatisticsJson() const return statsDoc.toJson( QJsonDocument::Compact ); } -QgsPointCloudStatistics QgsPointCloudStatistics::fromStatisticsJson( QByteArray statsByteArray ) +QgsPointCloudStatistics QgsPointCloudStatistics::fromStatisticsJson( const QByteArray &statsByteArray ) { QJsonParseError error; QJsonDocument document = QJsonDocument::fromJson( statsByteArray, &error );