Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script fails behind proxy #12

Closed
nisargjhaveri opened this issue Mar 23, 2015 · 5 comments · Fixed by #16
Closed

Installation script fails behind proxy #12

nisargjhaveri opened this issue Mar 23, 2015 · 5 comments · Fixed by #16

Comments

@nisargjhaveri
Copy link
Contributor

The script install.js which runs on installation fails downloading from http://dl.nwjs.io/v* behind proxy.

both $http_proxy shell variable and npm config proxy are set properly.

Probably problem with the download package that is being used, which uses a package called got which apparently does not support proxy like this.

It would be great if we can fix this. I am ready to assist if I can be useful.

Thanks.

@nisargjhaveri
Copy link
Contributor Author

Also, it seems like npm is not up-to-date with this repo.

@shama
Copy link
Contributor

shama commented Mar 24, 2015

Related issue sindresorhus/got#7

@shama
Copy link
Contributor

shama commented Mar 24, 2015

@nisargjhaveri Could you test if adding the option proxy: process.env.http_proxy to Download in scripts/install.js fixes the issue for you?

@nisargjhaveri
Copy link
Contributor Author

No it doesn't help adding proxy: process.env.http_proxy to new Download() call along with extract: true and other options.

@shama
Copy link
Contributor

shama commented Mar 24, 2015

I don't really have an easy way to tests this. So a PR that fixes this for you would be appreciated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants