Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilanguage support #4

Closed
brainrom opened this issue Feb 7, 2021 · 3 comments · Fixed by #19
Closed

Multilanguage support #4

brainrom opened this issue Feb 7, 2021 · 3 comments · Fixed by #19

Comments

@brainrom
Copy link

brainrom commented Feb 7, 2021

Exit menu can be translated in config file, but not "To workspace...", "Kill", etc. and have a language mess in system is not cool. So, minimal multilanguage will be very nice. I can add a translation engine and Russian translation by myself and then PR into master.

@nwg-piotr
Copy link
Owner

nwg-piotr commented Feb 7, 2021

This must wait. Having finished the config GUI (current progress: 20%), I'm going to check if coding the panel itself in Go brings some significant performance improvement. I'm not going to maintain versions in two languages in the future, so new features should be added in the finally chosen lang - python or golang.

@brainrom
Copy link
Author

brainrom commented Feb 7, 2021

IMHO, panel should stay on Python. This brings much more flexibility (like Qtile) with insufficient performance loss. Even on my Intel Celeron tablet, nwg-panel works a lot faster than C++ written waybar.

@nwg-piotr
Copy link
Owner

Well, python goes better with GTK due to the object-oriented approach. Also the code would be easier to maintain, and more likely to gain contributors. Some time ago I coded the same GTK-based stuff in python, and then again in Go, and the Go code is twice as long. But it works almost 2 times faster. There are pros and cons...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants