-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite installation code path #1204
Conversation
@@ -12,8 +22,11 @@ install: | |||
- chmod +x /tmp/urchin/package/urchin | |||
- '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y' | |||
script: | |||
- export CXX=g++-4.8 | |||
- export CC=gcc-4.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably use env
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'd have to define it once for each matrix item, instead of once for the entire build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env:
global:
- CXX=g++-4.8
- CC=gcc-4.8
Works as well.
https://docs.travis-ci.com/user/environment-variables/#Global-Variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks, that's great. I'll use that.
e9ac951
to
dcfa63f
Compare
- consolidate `nvm_install_merged_node_binary` with `nvm_install_node_binary` - add `nvm_get_download_slug`, `nvm_download_artifact` - `nvm uninstall` no longer removes artifacts
- `nvm uninstall` no longer removes source artifacts
…g, io.js too. - `nvm_get_checksum` now accepts 5 args (from 3): flavor (node/iojs), type (binary/source), version, slug, compression (xz/gz) - `nvm_install_binary` accepts 3 args (from 2): flavor (node/iojs), kind (std), version - remove `nvm_install_iojs_binary`
- cache the nvm cache on travis
- consolidate `nvm_install_iojs_source` and `nvm_install_node_source` into `nvm_install_source`
This PR rewrites the entire installation code path for nvm. This allows:
io.js
installation from sourcenode
v4+ installation from sourcenvm cache
commands to manage cached archivesinstallation_iojs
source tests are disabled, because they take too long in travis-ci to complete. I find this acceptable because the existing "install from source" code path is tested, and enough code is now shared that the risk is quite low.Fixes #1188. Fixes #1193. Fixes #700. Obviates #1192. Unblocks #1053 & #779.