Fresh install of NVM error due to CRLF newlines

[phillipsj]

After installation I receive the error. Not very good with BASH.

command not found
command not found
line 11: syntax error near unexpected token '$'{\r''
line 11: 'nvm_has() {

[ljharb]

What OS and shell are you using? Can you confirm that you installed nvm using the curl command in the readme?

[phillipsj]

Yes I installed using the curl command in the README.

OS: Xubuntu 14.04.2 LTS
Shell: BASH

[ljharb]

Thanks - at what step did you receive the error?

[phillipsj]

The install went perfect like I have done a dozen times. When I reload my shell to read my bashrc it throws the error when reading nvm.sh.

[ljharb]

Hmm, the \r in the error message suggests that there's a Windows line feed. Let me see if I can remove it.
edit: I don't see any \r characters in install.sh or nvm.sh.

[ljharb]

@phillipsj on the command line, if you type . $NVM_DIR/nvm.sh, what's the output?

[phillipsj]

jamie@xubu:$ $NVM_DIR/nvm.sh
/home/jamie/.nvm/nvm.sh: line 8: $'\r': command not found
/home/jamie/.nvm/nvm.sh: line 10: $'\r': command not found
/home/jamie/.nvm/nvm.sh: line 11: syntax error near unexpected token $'{\r'' 'home/jamie/.nvm/nvm.sh: line 11:nvm_has() {
jamie@xubu:$ . $NVM_DIR/nvm.sh
: command not found
: command not found
bash: /home/jamie/.nvm/nvm.sh: line 11: syntax error near unexpected token $'{\r'' 'ash: /home/jamie/.nvm/nvm.sh: line 11:nvm_has() {
jamie@xubu:~$

[ljharb]

The first command definitely shouldn't work at all, since it's not executable nor does it have a shebang.

The second, however, definitely should. Can you try deleting nvm.sh and rerunning curl https://raw.githubusercontent.com/creationix/nvm/v0.24.1/install.sh | bash?

[phillipsj]

Just try reinstalling and I am still getting the same error.

[ljharb]

@phillipsj The odd part is that you said you've used nvm before just fine on this machine - what does bash --version output?

[phillipsj]

This is a fresh install on a new VM. I will get you a bash version.

[phillipsj]

Here is my bash version:
GNU bash, version 4.3.11(1)-release (x86_64-pc-linux-gnu)

[fititnt]

@phillipsj same here. Solved converting Windows end line to Unix endline for file ~/.nvm/nvm.sh (with notepad++ under Wine) and worked.

Ubuntu 14.04 / GNU bash, versão 4.3.11(1)-release (x86_64-pc-linux-gnu)

[ljharb]

@fititnt It's hard to me to fix that, so if you can make a PR fixing that I'd be very happy :-)

[fititnt]

@ljharb Should be a better way to do it, because is a bit hacky that way. That should work even with \r. Maybe is just a problem with ubuntu or a missing #!/usr/bin/env bash at first line of the file

[ljharb]

@fititnt nvm.sh is sourced, not executed, so it doesn't need a shebang. Certainly it might be an issue with ubuntu, but I can't debug that any better :-/

[sixman9]

I'm also finding Windows-style line endings for NVM (wget'd), on my week-old Ubuntu 14.04 install.

Although 'Notepad under Wine' will probably do the job, I'd use the 'dos2unix' command (sudo apt-get install dos2unix on Ubuntu). Here's what I'm doing to the NVM install directory:

for lr in find ~/.nvm -type f; do dos2unix "$lr"; done

This command-line will find NVM's install files and removes '\r' line endings.

Once that's was done, I just closed and re-opened the terminal. All seems well now - I have many NVM-prefixed commands on the terminal now, thanks.

[phillipsj]

So I opened it in gedit and did a "Save As" and changed the line ending to unix/linux. GEdit did recognize it as windows line ending file.

[ljharb]

I think the issue for me is that I'm both on a Mac, and have my git settings set up to automatically make all line endings Unix.

Could someone with Windows try a pull request that removes all the windows newlines on install.sh and nvm.sh (@phillipsj, @sixman9, @fititnt?)

[phillipsj]

I should have the time later tonight and pull it down and submit the request. If someone else can get to it before feel free.

[ljharb]

@phillipsj looks like nobody has yet, if you still could that'd be awesome :-)

[phillipsj]

Yep I will.

[phillipsj]

Unfortunately the file names for the test directories are causing problems on a windows box.

[phillipsj]

Hopefully forcing the line endings in the gitattributes will work it out of the system. These are the most frustrating issues.

[phillipsj]

Submitted a new pull request. with the squash. I must be doing something wrong as I always have this pull requests issue.

[ljharb]

@phillipsj a force push to the same branch name (not deleting the branch on origin) should update the pull request neatly. nbd tho, thanks so much!