checksum fails when sha1sum is alias

[ghost]

on my system sha1sum is an alias

# OS X has no `sha1sum`, so use `shasum` as a fallback
command -v sha1sum > /dev/null || alias sha1sum="shasum"

so all nvm installs fails checksum

cr@MacBook:~|⇒  nvm install 0.11 
######################################################################## 100.0%
nvm_checksum:2: command not found: sha1sum
Checksums do not match.
Binary download failed, trying source.

i can workaround this issue by forcing nvm_checksum() to use shasum
or by removing sha1sum alias

nvm_checksum() {
  # if nvm_has "sha1sum"; then
  #   checksum="$(command sha1sum "$1" | command awk '{print $1}')"
  # elif nvm_has "sha1"; then
  #   checksum="$(command sha1 -q "$1")"
  # else
  checksum="$(shasum "$1" | command awk '{print $1}')"
  # fi

[ljharb]

@bhedana What version of nvm do you have? The latest explicitly checks for aliases to avoid this problem, and it doesn't appear you have the latest.

Also, builtins shouldn't be aliased as a general rule.

Please update your copy of nvm and let me know if it's still a problem.

[ghost]

this was freshly installed today using the command from the readme..

curl https://raw.githubusercontent.com/creationix/nvm/v0.23.3/install.sh | bash

[ljharb]

Oops, you're right :-) this is fixed in 820074e which isn't released yet. I'll release an update soon and this will fix your issue.

[ghost]

so i pulled master just to play and i think these latest changes need a little adjustment to solve my particular issue..

the nvm_is_alias check doesn't appear to be returning as expected

rs@aus-rs01-mac:~|⇒  type "sha1sum"
sha1sum is an alias for shasum

rs@aus-rs01-mac:~|⇒  command alias "sha1sum"
/usr/bin/alias: line 4: alias: sha1sum: not found

again.. the short answer is.. don't alias this command.. :-)

[ljharb]

@bhedana hmm, which shell are you using?

[ghost]

oh yes.. that's probably important... zsh

[ljharb]

Thanks - what does nvm_is_alias sha1sum ; echo $? report?

[ghost]

rs@aus-rs01-mac:~|⇒  nvm_is_alias sha1sum ; echo $?
1

[ljharb]

Gotcha, thanks. I do have unit tests for nvm_is_alias that run in zsh, so I think something else is going on, but clearly that subfunction doesn't work in zsh right now. I'll leave this open so that can be fixed - thanks for following up :-)

[ljharb]

Fixed with 12ca8f2